third_party/WebKit/Source/core/inspector/ScriptArguments.cpp - Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameConsole.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp b/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

index e7c47a56e983f80e67275eb8bad5ec34525292d4..f2ab1ff8ed1efe05ee68ec38b4085ec138f844d4 100644

--- a/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

+++ b/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

@@ -91,10 +91,6 @@ private:

}

if (value->IsArray())

return append(v8::Local<v8::Array>::Cast(value));

- if (toDOMWindow(m_isolate, value)) {

- m_builder.append("[object Window]");

- return true;

- }

if (value->IsProxy()) {

m_builder.append("[object Proxy]");

return true;