Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Issue 2035413003: Revert of Provide a tagged allocation top pointer. (Closed)

Created:
4 years, 6 months ago by epertoso
Modified:
4 years, 6 months ago
CC:
ahaas, titzer, ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Provide a tagged allocation top pointer. (patchset #5 id:80001 of https://codereview.chromium.org/2028633002/ ) Reason for revert: d8 segfaults on some benchmarks on ia32. Investigating. Original issue's description: > Provide a tagged allocation top pointer. > > Taking over http://crrev.com/1924223002. > > BUG=chromium:606711 > LOG=N > > Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028 > Committed: https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341 > Cr-Original-Commit-Position: refs/heads/master@{#36633} > Cr-Commit-Position: refs/heads/master@{#36742} TBR=bmeurer@chromium.org,hpayer@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:606711 Committed: https://crrev.com/d8c2b8f98212b07a572f52b39d91b8bcb30f296f Cr-Commit-Position: refs/heads/master@{#36758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -127 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 10 chunks +20 lines, -14 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 5 chunks +13 lines, -3 lines 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/memory-optimizer.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 chunk +37 lines, -25 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 11 chunks +29 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 8 chunks +19 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 7 chunks +19 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 8 chunks +16 lines, -5 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 9 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
epertoso
Created Revert of Provide a tagged allocation top pointer.
4 years, 6 months ago (2016-06-06 15:11:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035413003/1
4 years, 6 months ago (2016-06-06 15:11:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 15:12:21 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 15:12:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8c2b8f98212b07a572f52b39d91b8bcb30f296f
Cr-Commit-Position: refs/heads/master@{#36758}

Powered by Google App Engine
This is Rietveld 408576698