Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2028633002: Provide a tagged allocation top pointer.

Created:
4 years, 6 months ago by epertoso
Modified:
3 years, 10 months ago
CC:
ahaas, ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide a tagged allocation top pointer. Taking over http://crrev.com/1924223002. BUG=chromium:606711 LOG=N Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028 Committed: https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341 Cr-Original-Commit-Position: refs/heads/master@{#36633} Cr-Commit-Position: refs/heads/master@{#36742}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Total comments: 2

Patch Set 4 : Update #

Patch Set 5 : Update #

Patch Set 6 : WIP: adding a few tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+817 lines, -208 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 10 chunks +14 lines, -20 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 5 5 chunks +2 lines, -12 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/memory-optimizer.cc View 4 chunks +3 lines, -14 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/globals.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 1 chunk +17 lines, -29 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 11 chunks +12 lines, -30 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 8 chunks +9 lines, -19 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 8 chunks +8 lines, -18 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 8 chunks +5 lines, -16 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 2 3 4 5 5 chunks +17 lines, -9 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 3 4 5 9 chunks +19 lines, -15 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 2 3 4 5 2 chunks +109 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-ia32.cc View 1 2 3 4 5 3 chunks +206 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 2 3 4 5 4 chunks +115 lines, -7 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 2 3 4 5 2 chunks +65 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 2 3 4 5 3 chunks +194 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028633002/1
4 years, 6 months ago (2016-05-31 14:08:26 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/18221)
4 years, 6 months ago (2016-05-31 14:25:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028633002/20001
4 years, 6 months ago (2016-05-31 15:06:27 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/6538)
4 years, 6 months ago (2016-05-31 15:12:00 UTC) #10
epertoso
4 years, 6 months ago (2016-05-31 15:30:26 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028633002/40001
4 years, 6 months ago (2016-05-31 15:30:37 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 15:58:25 UTC) #15
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h#newcode1664 src/heap/spaces.h:1664: // Current allocation limit. Mention that limit is ...
4 years, 6 months ago (2016-05-31 18:19:35 UTC) #16
Benedikt Meurer
LGTM.
4 years, 6 months ago (2016-05-31 18:47:21 UTC) #17
epertoso
https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h#newcode1664 src/heap/spaces.h:1664: // Current allocation limit. On 2016/05/31 at 18:19:35, Hannes ...
4 years, 6 months ago (2016-06-01 08:06:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028633002/60001
4 years, 6 months ago (2016-06-01 08:06:31 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-01 08:37:28 UTC) #22
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028 Cr-Commit-Position: refs/heads/master@{#36633}
4 years, 6 months ago (2016-06-01 08:39:16 UTC) #24
Michael Achenbach
FYI: This leads to flaky crashes in a wasm test: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/10598 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/2528
4 years, 6 months ago (2016-06-01 10:32:11 UTC) #26
epertoso
On 2016/06/01 at 10:32:11, machenbach wrote: > FYI: This leads to flaky crashes in a ...
4 years, 6 months ago (2016-06-01 11:00:52 UTC) #27
epertoso
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2031493002/ by epertoso@chromium.org. ...
4 years, 6 months ago (2016-06-01 11:01:56 UTC) #28
epertoso
On 2016/06/01 at 11:01:56, epertoso wrote: > A revert of this CL (patchset #4 id:60001) ...
4 years, 6 months ago (2016-06-06 10:49:08 UTC) #29
Michael Achenbach
On 2016/06/06 10:49:08, epertoso wrote: > On 2016/06/01 at 11:01:56, epertoso wrote: > > A ...
4 years, 6 months ago (2016-06-06 11:02:28 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028633002/80001
4 years, 6 months ago (2016-06-06 12:01:53 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-06 12:30:28 UTC) #34
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341 Cr-Commit-Position: refs/heads/master@{#36742}
4 years, 6 months ago (2016-06-06 12:32:06 UTC) #36
epertoso
4 years, 6 months ago (2016-06-06 15:11:41 UTC) #37
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2035413003/ by epertoso@chromium.org.

The reason for reverting is: d8 segfaults on some benchmarks on ia32.
Investigating..

Powered by Google App Engine
This is Rietveld 408576698