Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2035413003: Revert of Provide a tagged allocation top pointer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h" 7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 4948 matching lines...) Expand 10 before | Expand all | Expand 10 after
4959 AllocationFlags allocation_flags = NO_ALLOCATION_FLAGS; 4959 AllocationFlags allocation_flags = NO_ALLOCATION_FLAGS;
4960 if (instr->hydrogen()->IsOldSpaceAllocation()) { 4960 if (instr->hydrogen()->IsOldSpaceAllocation()) {
4961 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 4961 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
4962 allocation_flags = static_cast<AllocationFlags>(flags | PRETENURE); 4962 allocation_flags = static_cast<AllocationFlags>(flags | PRETENURE);
4963 } 4963 }
4964 // If the allocation folding dominator allocate triggered a GC, allocation 4964 // If the allocation folding dominator allocate triggered a GC, allocation
4965 // happend in the runtime. We have to reset the top pointer to virtually 4965 // happend in the runtime. We have to reset the top pointer to virtually
4966 // undo the allocation. 4966 // undo the allocation.
4967 ExternalReference allocation_top = 4967 ExternalReference allocation_top =
4968 AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags); 4968 AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags);
4969 __ sub(eax, Immediate(kHeapObjectTag));
4969 __ mov(Operand::StaticVariable(allocation_top), eax); 4970 __ mov(Operand::StaticVariable(allocation_top), eax);
4971 __ add(eax, Immediate(kHeapObjectTag));
4970 } 4972 }
4971 } 4973 }
4972 4974
4973 4975
4974 void LCodeGen::DoTypeof(LTypeof* instr) { 4976 void LCodeGen::DoTypeof(LTypeof* instr) {
4975 DCHECK(ToRegister(instr->context()).is(esi)); 4977 DCHECK(ToRegister(instr->context()).is(esi));
4976 DCHECK(ToRegister(instr->value()).is(ebx)); 4978 DCHECK(ToRegister(instr->value()).is(ebx));
4977 Label end, do_call; 4979 Label end, do_call;
4978 Register value_register = ToRegister(instr->value()); 4980 Register value_register = ToRegister(instr->value());
4979 __ JumpIfNotSmi(value_register, &do_call); 4981 __ JumpIfNotSmi(value_register, &do_call);
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
5318 __ bind(deferred->exit()); 5320 __ bind(deferred->exit());
5319 __ bind(&done); 5321 __ bind(&done);
5320 } 5322 }
5321 5323
5322 #undef __ 5324 #undef __
5323 5325
5324 } // namespace internal 5326 } // namespace internal
5325 } // namespace v8 5327 } // namespace v8
5326 5328
5327 #endif // V8_TARGET_ARCH_IA32 5329 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698