Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: src/crankshaft/mips64/lithium-codegen-mips64.cc

Issue 2035413003: Revert of Provide a tagged allocation top pointer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips/lithium-codegen-mips.cc ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/mips64/lithium-codegen-mips64.h" 5 #include "src/crankshaft/mips64/lithium-codegen-mips64.h"
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/mips64/lithium-gap-resolver-mips64.h" 10 #include "src/crankshaft/mips64/lithium-gap-resolver-mips64.h"
(...skipping 5327 matching lines...) Expand 10 before | Expand all | Expand 10 after
5338 if (instr->hydrogen()->IsOldSpaceAllocation()) { 5338 if (instr->hydrogen()->IsOldSpaceAllocation()) {
5339 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 5339 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
5340 allocation_flags = static_cast<AllocationFlags>(flags | PRETENURE); 5340 allocation_flags = static_cast<AllocationFlags>(flags | PRETENURE);
5341 } 5341 }
5342 // If the allocation folding dominator allocate triggered a GC, allocation 5342 // If the allocation folding dominator allocate triggered a GC, allocation
5343 // happend in the runtime. We have to reset the top pointer to virtually 5343 // happend in the runtime. We have to reset the top pointer to virtually
5344 // undo the allocation. 5344 // undo the allocation.
5345 ExternalReference allocation_top = 5345 ExternalReference allocation_top =
5346 AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags); 5346 AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags);
5347 Register top_address = scratch0(); 5347 Register top_address = scratch0();
5348 __ Dsubu(v0, v0, Operand(kHeapObjectTag));
5348 __ li(top_address, Operand(allocation_top)); 5349 __ li(top_address, Operand(allocation_top));
5349 __ sd(v0, MemOperand(top_address)); 5350 __ sd(v0, MemOperand(top_address));
5351 __ Daddu(v0, v0, Operand(kHeapObjectTag));
5350 } 5352 }
5351 } 5353 }
5352 5354
5353 void LCodeGen::DoFastAllocate(LFastAllocate* instr) { 5355 void LCodeGen::DoFastAllocate(LFastAllocate* instr) {
5354 DCHECK(instr->hydrogen()->IsAllocationFolded()); 5356 DCHECK(instr->hydrogen()->IsAllocationFolded());
5355 DCHECK(!instr->hydrogen()->IsAllocationFoldingDominator()); 5357 DCHECK(!instr->hydrogen()->IsAllocationFoldingDominator());
5356 Register result = ToRegister(instr->result()); 5358 Register result = ToRegister(instr->result());
5357 Register scratch1 = ToRegister(instr->temp1()); 5359 Register scratch1 = ToRegister(instr->temp1());
5358 Register scratch2 = ToRegister(instr->temp2()); 5360 Register scratch2 = ToRegister(instr->temp2());
5359 5361
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
5759 __ ld(result, FieldMemOperand(scratch, 5761 __ ld(result, FieldMemOperand(scratch,
5760 FixedArray::kHeaderSize - kPointerSize)); 5762 FixedArray::kHeaderSize - kPointerSize));
5761 __ bind(deferred->exit()); 5763 __ bind(deferred->exit());
5762 __ bind(&done); 5764 __ bind(&done);
5763 } 5765 }
5764 5766
5765 #undef __ 5767 #undef __
5766 5768
5767 } // namespace internal 5769 } // namespace internal
5768 } // namespace v8 5770 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/mips/lithium-codegen-mips.cc ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698