Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: src/code-stub-assembler.cc

Issue 2035413003: Revert of Provide a tagged allocation top pointer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/compiler/memory-optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.cc
diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc
index 610492f39126bf3819f88d3440c8aafe8595316a..27f39a7f1068e2006f26c5a42d0426687ea85c7c 100644
--- a/src/code-stub-assembler.cc
+++ b/src/code-stub-assembler.cc
@@ -375,7 +375,9 @@
Node* no_runtime_result = top;
StoreNoWriteBarrier(MachineType::PointerRepresentation(), top_address,
new_top);
- result.Bind(BitcastWordToTagged(no_runtime_result));
+ no_runtime_result = BitcastWordToTagged(
+ IntPtrAdd(no_runtime_result, IntPtrConstant(kHeapObjectTag)));
+ result.Bind(no_runtime_result);
Goto(&merge_runtime);
Bind(&merge_runtime);
@@ -393,9 +395,8 @@
if (flags & kDoubleAlignment) {
// TODO(epertoso): Simd128 alignment.
Label aligned(this), not_aligned(this), merge(this, &adjusted_size);
- Branch(WordAnd(IntPtrSub(top, IntPtrConstant(kHeapObjectTag)),
- IntPtrConstant(kDoubleAlignmentMask)),
- &not_aligned, &aligned);
+ Branch(WordAnd(top, IntPtrConstant(kDoubleAlignmentMask)), &not_aligned,
+ &aligned);
Bind(&not_aligned);
Node* not_aligned_size =
@@ -421,8 +422,7 @@
// Store a filler and increase the address by kPointerSize.
// TODO(epertoso): this code assumes that we only align to kDoubleSize. Change
// it when Simd128 alignment is supported.
- StoreNoWriteBarrier(MachineType::PointerRepresentation(),
- IntPtrSub(top, IntPtrConstant(1)),
+ StoreNoWriteBarrier(MachineType::PointerRepresentation(), top,
LoadRoot(Heap::kOnePointerFillerMapRootIndex));
address.Bind(BitcastWordToTagged(
IntPtrAdd(address.value(), IntPtrConstant(kPointerSize))));
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/compiler/memory-optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698