Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 2035413003: Revert of Provide a tagged allocation top pointer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1484 matching lines...) Expand 10 before | Expand all | Expand 10 after
1495 if (instr->hydrogen()->IsOldSpaceAllocation()) { 1495 if (instr->hydrogen()->IsOldSpaceAllocation()) {
1496 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 1496 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
1497 allocation_flags = static_cast<AllocationFlags>(flags | PRETENURE); 1497 allocation_flags = static_cast<AllocationFlags>(flags | PRETENURE);
1498 } 1498 }
1499 // If the allocation folding dominator allocate triggered a GC, allocation 1499 // If the allocation folding dominator allocate triggered a GC, allocation
1500 // happend in the runtime. We have to reset the top pointer to virtually 1500 // happend in the runtime. We have to reset the top pointer to virtually
1501 // undo the allocation. 1501 // undo the allocation.
1502 ExternalReference allocation_top = 1502 ExternalReference allocation_top =
1503 AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags); 1503 AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags);
1504 Register top_address = x10; 1504 Register top_address = x10;
1505 __ Sub(x0, x0, Operand(kHeapObjectTag));
1505 __ Mov(top_address, Operand(allocation_top)); 1506 __ Mov(top_address, Operand(allocation_top));
1506 __ Str(x0, MemOperand(top_address)); 1507 __ Str(x0, MemOperand(top_address));
1508 __ Add(x0, x0, Operand(kHeapObjectTag));
1507 } 1509 }
1508 } 1510 }
1509 1511
1510 void LCodeGen::DoFastAllocate(LFastAllocate* instr) { 1512 void LCodeGen::DoFastAllocate(LFastAllocate* instr) {
1511 DCHECK(instr->hydrogen()->IsAllocationFolded()); 1513 DCHECK(instr->hydrogen()->IsAllocationFolded());
1512 DCHECK(!instr->hydrogen()->IsAllocationFoldingDominator()); 1514 DCHECK(!instr->hydrogen()->IsAllocationFoldingDominator());
1513 Register result = ToRegister(instr->result()); 1515 Register result = ToRegister(instr->result());
1514 Register scratch1 = ToRegister(instr->temp1()); 1516 Register scratch1 = ToRegister(instr->temp1());
1515 Register scratch2 = ToRegister(instr->temp2()); 1517 Register scratch2 = ToRegister(instr->temp2());
1516 1518
(...skipping 4232 matching lines...) Expand 10 before | Expand all | Expand 10 after
5749 // Index is equal to negated out of object property index plus 1. 5751 // Index is equal to negated out of object property index plus 1.
5750 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5752 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5751 __ Ldr(result, FieldMemOperand(result, 5753 __ Ldr(result, FieldMemOperand(result,
5752 FixedArray::kHeaderSize - kPointerSize)); 5754 FixedArray::kHeaderSize - kPointerSize));
5753 __ Bind(deferred->exit()); 5755 __ Bind(deferred->exit());
5754 __ Bind(&done); 5756 __ Bind(&done);
5755 } 5757 }
5756 5758
5757 } // namespace internal 5759 } // namespace internal
5758 } // namespace v8 5760 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698