Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586
Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
Cr-Commit-Position: refs/heads/master@{#398151}

[sashab, 2016-06-06 03:52:44]

sashab@chromium.org changed reviewers:
+ timloh@chromium.org

[Yuki, 2016-06-06 05:49:55]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-06-06 05:49:56]

bindings/ LGTM.

[sashab, 2016-06-06 05:50:31]

sashab@chromium.org changed reviewers:
- yukishiino@chromium.org

[sashab, 2016-06-06 05:50:33]

Everything is a mechanical change (adding consts) except what's marked

https://codereview.chromium.org/2034013002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/2034013002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingStyle.cpp:1191:
m_mutableStyle->setProperty(property.id(), result, property.isImportant());
This is the only behavior change that needs real review (this and the change to
mergeTextDecorationValues above)

https://codereview.chromium.org/2034013002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingStyle.cpp:1618: const CSSValue*
textDecoration = style->getPropertyCSSValue(propertyID);
Typo fix hehe

[haraken, 2016-06-06 05:51:04]

LGTM

[sashab, 2016-06-06 06:37:34]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[sashab, 2016-06-06 22:48:56]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-06-06 22:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034013002/40001

[commit-bot: I haz the power, 2016-06-06 22:54:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 22:56:43]

Description was changed from

==========
Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586
==========

to

==========
Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586

Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
Cr-Commit-Position: refs/heads/master@{#398151}
==========

[commit-bot: I haz the power, 2016-06-06 22:56:44]

Patchset 3 (id:??) landed as
https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
Cr-Commit-Position: refs/heads/master@{#398151}

[erikchen, 2016-06-06 23:11:14]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2042113002/ by erikchen@chromium.org.

The reason for reverting is: """
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15:
error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue
of type 'const blink::CSSValue *'
    CSSValue* cssValue =
m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20....