Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2037973002: Make CSSProperty store a const CSSValue (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_stylepropertyset_use_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSProperty store a const CSSValue Make CSSProperty store a Member<const CSSValue>, instead of a Member<CSSValue>. This is pre-work for making CSSValueLists store const CSSValues. BUG=526586 Committed: https://crrev.com/f6e96d2d4e8ba4d806e3290eaf4d797184278380 Cr-Commit-Position: refs/heads/master@{#398010}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperty.h View 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
sashab
4 years, 6 months ago (2016-06-06 02:44:39 UTC) #2
Timothy Loh
On 2016/06/06 02:44:39, sashab wrote: lgtm
4 years, 6 months ago (2016-06-06 03:07:32 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2032613007 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-06 05:48:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037973002/20001
4 years, 6 months ago (2016-06-06 12:24:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 12:27:43 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 12:29:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6e96d2d4e8ba4d806e3290eaf4d797184278380
Cr-Commit-Position: refs/heads/master@{#398010}

Powered by Google App Engine
This is Rietveld 408576698