Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2032243003: Make CSSValueList store const CSSValues (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_computedstyledeclaration_return_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSValueList store const CSSValues Make CSSValueList store a vector of Member<const CSSValue> instead of Member<CSSValue>. This also involved updating ComputedStyleCSSValueMapping::get() to return a const CSSValue* in the same patch (both changes require eachother to be const). This patch is entirely mechanical and just adds consts to all callsites that are needed. BUG=526586 Committed: https://crrev.com/982156aa8a961ec7b279a869caf16bbeab1a9ccb Cr-Commit-Position: refs/heads/master@{#398465}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Small fix n CSSOM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 2 3 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
sashab
4 years, 6 months ago (2016-06-06 03:52:38 UTC) #2
sashab
This patch is entirely mechanical; just a bunch of consts :)
4 years, 6 months ago (2016-06-06 05:55:08 UTC) #3
sashab
4 years, 6 months ago (2016-06-06 06:37:39 UTC) #4
Timothy Loh
On 2016/06/06 06:37:39, sashab wrote: lgtm
4 years, 6 months ago (2016-06-07 03:18:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032243003/20001
4 years, 6 months ago (2016-06-07 06:53:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/17263) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 06:55:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032243003/60001
4 years, 6 months ago (2016-06-07 23:43:57 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-08 02:33:47 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 02:35:36 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/982156aa8a961ec7b279a869caf16bbeab1a9ccb
Cr-Commit-Position: refs/heads/master@{#398465}

Powered by Google App Engine
This is Rietveld 408576698