third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 2034013002: Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 2034013002: Make CSSComputedStyledeclaration::getPropertyCSSValue return const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssproperty_store_const

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h » ('j') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

index 96b6d9aeb3774c101f47404302d6b0386ec0a5dd..9d3e97215055c26aa3306c340e496bc8e39c3667 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -195,7 +195,7 @@ void V8CSSStyleDeclaration::namedPropertyGetterCustom(v8::Local<v8::Name> name,

CSSStyleDeclaration* impl = V8CSSStyleDeclaration::toImpl(info.Holder());

// TODO(leviw): This API doesn't support custom properties.

- CSSValue* cssValue = impl->getPropertyCSSValueInternal(resolvedProperty);

+ const CSSValue* cssValue = impl->getPropertyCSSValueInternal(resolvedProperty);

if (cssValue) {

v8SetReturnValueStringOrNull(info, cssValue->cssText(), info.GetIsolate());

return;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h » ('j') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('J')