third_party/WebKit/Source/core/css/CSSStyleDeclaration.h - Issue 2034013002: Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

Issue 2034013002: Make CSSComputedStyledeclaration::getPropertyCSSValue return const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssproperty_store_const

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | third_party/WebKit/Source/core/css/CSSValueList.h » ('j') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

diff --git a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

index 531cdef72a8ea8c2a98f4f0fa5894cab35486fe9..9f4464cf4ab3ec9793cc215c3cc2a71722cca407 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

+++ b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

@@ -65,7 +65,7 @@ public:

// CSSPropertyID versions of the CSSOM functions to support bindings and editing.

// Use the non-virtual methods in the concrete subclasses when possible.

// The CSSValue returned by this function should not be exposed to the web as it may be used by multiple documents at the same time.

- virtual CSSValue* getPropertyCSSValueInternal(CSSPropertyID) = 0;

+ virtual const CSSValue* getPropertyCSSValueInternal(CSSPropertyID) = 0;

virtual String getPropertyValueInternal(CSSPropertyID) = 0;

virtual void setPropertyInternal(CSSPropertyID, const String& propertyValue, const String& value, bool important, ExceptionState&) = 0;