third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h - Issue 2034013002: Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

Issue 2034013002: Make CSSComputedStyledeclaration::getPropertyCSSValue return const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssproperty_store_const

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp ('k') | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

index faa991061592116f5129bb70131e5e7d51068860..e2b4de73a0d7d4096794f3a5d5c6c68592a4add3 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

@@ -58,11 +58,11 @@ public:

MutableStylePropertySet* copyProperties() const;

- CSSValue* getPropertyCSSValue(CSSPropertyID) const;

- CSSValue* getPropertyCSSValue(AtomicString customPropertyName) const;

+ const CSSValue* getPropertyCSSValue(CSSPropertyID) const;

+ const CSSValue* getPropertyCSSValue(AtomicString customPropertyName) const;

std::unique_ptr<HashMap<AtomicString, RefPtr<CSSVariableData>>> getVariables() const;

- CSSValue* getFontSizeCSSValuePreferringKeyword() const;

+ const CSSValue* getFontSizeCSSValuePreferringKeyword() const;

bool isMonospaceFont() const;

MutableStylePropertySet* copyPropertiesInSet(const Vector<CSSPropertyID>&) const;

@@ -94,7 +94,7 @@ private:

void setCSSFloat(const String&, ExceptionState&);

String cssText() const override;

void setCSSText(const String&, ExceptionState&) override;

- CSSValue* getPropertyCSSValueInternal(CSSPropertyID) override;

+ const CSSValue* getPropertyCSSValueInternal(CSSPropertyID) override;

String getPropertyValueInternal(CSSPropertyID) override;

void setPropertyInternal(CSSPropertyID, const String& customPropertyName, const String& value, bool important, ExceptionState&) override;