Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2035333002: Removed deprecated method CSSValueList::itemWithBoundsCheck() (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_and_computedstylemapping_store_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed deprecated method CSSValueList::itemWithBoundsCheck() Removed deprecated CSSValueList::itemWithBoundsCheck() and the last remaining callsite. R=timloh@chromium.org Committed: https://crrev.com/0f6e1b81350d028e39c7e4c3f8252ea7c007c6b4 Cr-Commit-Position: refs/heads/master@{#398493}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
sashab
4 years, 6 months ago (2016-06-06 02:40:46 UTC) #1
Timothy Loh
https://codereview.chromium.org/2035333002/diff/1/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp File third_party/WebKit/Source/core/css/StylePropertySerializer.cpp (right): https://codereview.chromium.org/2035333002/diff/1/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp#newcode703 third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:703: // Might return 0 if there is not an ...
4 years, 6 months ago (2016-06-06 03:11:06 UTC) #2
sashab
https://codereview.chromium.org/2035333002/diff/1/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp File third_party/WebKit/Source/core/css/StylePropertySerializer.cpp (right): https://codereview.chromium.org/2035333002/diff/1/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp#newcode703 third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:703: // Might return 0 if there is not an ...
4 years, 6 months ago (2016-06-06 03:36:51 UTC) #3
Timothy Loh
lgtm
4 years, 6 months ago (2016-06-06 04:31:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035333002/40001
4 years, 6 months ago (2016-06-08 02:34:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/83822)
4 years, 6 months ago (2016-06-08 03:46:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035333002/60001
4 years, 6 months ago (2016-06-08 03:51:13 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-08 06:32:48 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 06:34:44 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0f6e1b81350d028e39c7e4c3f8252ea7c007c6b4
Cr-Commit-Position: refs/heads/master@{#398493}

Powered by Google App Engine
This is Rietveld 408576698