third_party/WebKit/Source/core/css/CSSValueList.cpp - Issue 2032243003: Make CSSValueList store const CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValueList.cpp

Issue 2032243003: Make CSSValueList store const CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_computedstyledeclaration_return_const

Patch Set: Small fix n CSSOM Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSValueList.h ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSValueList.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSValueList.cpp b/third_party/WebKit/Source/core/css/CSSValueList.cpp

index c00c5bbb34479df87ee436da841ea10df259423a..a95f27fdcdb9942a940019b73ec8cb76b674c48f 100644

--- a/third_party/WebKit/Source/core/css/CSSValueList.cpp

+++ b/third_party/WebKit/Source/core/css/CSSValueList.cpp

@@ -42,7 +42,7 @@ bool CSSValueList::removeAll(const CSSValue& val)

{

bool found = false;

for (int index = m_values.size() - 1; index >= 0; --index) {

- Member<CSSValue>& value = m_values.at(index);

+ Member<const CSSValue>& value = m_values.at(index);

if (value && value->equals(val)) {

m_values.remove(index);

found = true;

@@ -55,7 +55,7 @@ bool CSSValueList::removeAll(const CSSValue& val)

bool CSSValueList::hasValue(const CSSValue& val) const

{

for (size_t index = 0; index < m_values.size(); index++) {

- const Member<CSSValue>& value = m_values.at(index);

+ const Member<const CSSValue>& value = m_values.at(index);

if (value && value->equals(val))

return true;

}