third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp - Issue 2032243003: Make CSSValueList store const CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2032243003: Make CSSValueList store const CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_computedstyledeclaration_return_const

Patch Set: Small fix n CSSOM Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

index 97d326e2eaabaf65ca350e8b3e516d0004f0015d..19aa71753aae9d042a2c27a3c5eb551c36db32e3 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -143,7 +143,7 @@ static FontDescription::GenericFamilyType convertGenericFamily(CSSValueID valueI

}

-static bool convertFontFamilyName(StyleResolverState& state, CSSValue& value,

+static bool convertFontFamilyName(StyleResolverState& state, const CSSValue& value,

FontDescription::GenericFamilyType& genericFamily, AtomicString& familyName)

{

if (value.isFontFamilyValue()) {

@@ -487,7 +487,7 @@ GridPosition StyleBuilderConverter::convertGridPosition(StyleResolverState&, con

String gridLineName;

auto it = values.begin();

- CSSValue* currentValue = it->get();

+ const CSSValue* currentValue = it->get();

if (currentValue->isPrimitiveValue() && toCSSPrimitiveValue(currentValue)->getValueID() == CSSValueSpan) {

isSpanPosition = true;

++it;