third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp - Issue 2032243003: Make CSSValueList store const CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

Issue 2032243003: Make CSSValueList store const CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_computedstyledeclaration_return_const

Patch Set: Small fix n CSSOM Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/RuleFeature.cpp ('k') | third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

index 9b5aeb6a73bd6efe7ade6692ffa5c73129e0b9a1..9b45961275200e3d0d1d3ec012d4714351498b3f 100644

--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

@@ -128,7 +128,7 @@ StylePropertyMap::StyleValueVector StylePropertyMap::cssValueToStyleValueVector(

return styleValueVector;

}

- for (CSSValue* value : *toCSSValueList(&cssValue)) {

+ for (const CSSValue* value : toCSSValueList(cssValue)) {

CSSStyleValue* styleValue = StyleValueFactory::create(propertyID, *value);

if (!styleValue)

return StyleValueVector();