third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h - Issue 2032243003: Make CSSValueList store const CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h

Issue 2032243003: Make CSSValueList store const CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_computedstyledeclaration_return_const

Patch Set: Small fix n CSSOM Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSValueList.cpp ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h

index 0c1ff6123f9fe4dc19ebd77b4cf9dfcf8f97f583..b75b71fbf3f12d1ba99f3665889e4c3416c47e5d 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h

@@ -24,8 +24,8 @@ class ComputedStyleCSSValueMapping {

STATIC_ONLY(ComputedStyleCSSValueMapping);

public:

// FIXME: Resolve computed auto alignment in applyProperty/ComputedStyle and remove this non-const styledNode parameter.

- static CSSValue* get(CSSPropertyID, const ComputedStyle&, const LayoutObject* = nullptr, Node* styledNode = nullptr, bool allowVisitedStyle = false);

- static CSSValue* get(const AtomicString customPropertyName, const ComputedStyle&);

+ static const CSSValue* get(CSSPropertyID, const ComputedStyle&, const LayoutObject* = nullptr, Node* styledNode = nullptr, bool allowVisitedStyle = false);

+ static const CSSValue* get(const AtomicString customPropertyName, const ComputedStyle&);

static std::unique_ptr<HashMap<AtomicString, RefPtr<CSSVariableData>>> getVariables(const ComputedStyle&);

private:

static CSSValue* currentColorOrValidColor(const ComputedStyle&, const StyleColor&);