components/font_service/public/cpp/font_service_thread.cc - Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/font_service/public/cpp/font_service_thread.cc

Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: rm comment explaining true/false Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_service_autofill_unittest.cc ('k') | components/leveldb/leveldb_mojo_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/font_service/public/cpp/font_service_thread.cc

diff --git a/components/font_service/public/cpp/font_service_thread.cc b/components/font_service/public/cpp/font_service_thread.cc

index c0566ddcf11be958df6c95a8a2e95d1a57a91a5c..5d9645acea19f90b3da3103fc319a5e6323a2384 100644

--- a/components/font_service/public/cpp/font_service_thread.cc

+++ b/components/font_service/public/cpp/font_service_thread.cc

@@ -37,7 +37,9 @@ bool FontServiceThread::MatchFamilyName(

bool out_valid = false;

// This proxies to the other thread, which proxies to mojo. Only on the reply

// from mojo do we return from this.

- base::WaitableEvent done_event(false, false);

+ base::WaitableEvent done_event(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

task_runner()->PostTask(

FROM_HERE,

base::Bind(&FontServiceThread::MatchFamilyNameImpl, this, &done_event,

@@ -55,7 +57,9 @@ scoped_refptr<MappedFontFile> FontServiceThread::OpenStream(

base::File stream_file;

// This proxies to the other thread, which proxies to mojo. Only on the reply

// from mojo do we return from this.

- base::WaitableEvent done_event(false, false);

+ base::WaitableEvent done_event(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

task_runner()->PostTask(FROM_HERE,

base::Bind(&FontServiceThread::OpenStreamImpl, this,

&done_event, &stream_file, identity.fID));