components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc - Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: rm comment explaining true/false Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/child/webthread_impl_for_worker_scheduler.cc ('k') | components/storage_monitor/media_storage_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

diff --git a/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc b/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

index c8035c893a4be06b161a8738406746f6023cb735..13a777b04b5269f33436bc36d23c8b376f7f7a30 100644

--- a/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

+++ b/components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

@@ -98,7 +98,9 @@ class WebThreadImplForWorkerSchedulerTest : public testing::Test {

void RunOnWorkerThread(const tracked_objects::Location& from_here,

const base::Closure& task) {

- base::WaitableEvent completion(false, false);

+ base::WaitableEvent completion(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

thread_->GetTaskRunner()->PostTask(

from_here,

base::Bind(&WebThreadImplForWorkerSchedulerTest::RunOnWorkerThreadTask,

@@ -120,7 +122,9 @@ class WebThreadImplForWorkerSchedulerTest : public testing::Test {

TEST_F(WebThreadImplForWorkerSchedulerTest, TestDefaultTask) {

std::unique_ptr<MockTask> task(new MockTask());

- base::WaitableEvent completion(false, false);

+ base::WaitableEvent completion(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

EXPECT_CALL(*task, run());

ON_CALL(*task, run())

@@ -134,7 +138,9 @@ TEST_F(WebThreadImplForWorkerSchedulerTest, TestDefaultTask) {

TEST_F(WebThreadImplForWorkerSchedulerTest,

TestTaskExecutedBeforeThreadDeletion) {

std::unique_ptr<MockTask> task(new MockTask());

- base::WaitableEvent completion(false, false);

+ base::WaitableEvent completion(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

EXPECT_CALL(*task, run());

ON_CALL(*task, run())

@@ -147,7 +153,9 @@ TEST_F(WebThreadImplForWorkerSchedulerTest,

TEST_F(WebThreadImplForWorkerSchedulerTest, TestIdleTask) {

std::unique_ptr<MockIdleTask> task(new MockIdleTask());

- base::WaitableEvent completion(false, false);

+ base::WaitableEvent completion(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

EXPECT_CALL(*task, run(_));

ON_CALL(*task, run(_))