components/bookmarks/browser/bookmark_model.cc - Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: rm comment explaining true/false Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/web_data_service_unittest.cc ('k') | components/browser_sync/browser/profile_sync_service_autofill_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_model.cc

diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc

index 390a2316134f1a15c043f5c7faac2628e34459d4..8d5b238a0c9a1d8cb90266e87f85b2d268dfb6d8 100644

--- a/components/bookmarks/browser/bookmark_model.cc

+++ b/components/bookmarks/browser/bookmark_model.cc

@@ -117,7 +117,8 @@ BookmarkModel::BookmarkModel(std::unique_ptr<BookmarkClient> client)

next_node_id_(1),

observers_(

base::ObserverList<BookmarkModelObserver>::NOTIFY_EXISTING_ONLY),

- loaded_signal_(true, false),

+ loaded_signal_(base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED),

extensive_changes_(0),

undo_delegate_(nullptr),

empty_undo_delegate_(new EmptyUndoDelegate) {