Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue. BUG= Committed: https://crrev.com/5f265d3bfac30c73f2e25c6c8321de693c9db5de Cr-Commit-Position: refs/heads/master@{#397133}

Patch Set 1 #

Patch Set 2 : Synced. #

Messages

Total messages: 14 (7 generated)
Yuki
Could you review this CL?
4 years, 6 months ago (2016-06-01 10:12:59 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-01 11:06:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023213002/1
4 years, 6 months ago (2016-06-01 11:44:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-01 11:47:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023213002/20001
4 years, 6 months ago (2016-06-01 11:56:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 14:11:08 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 14:13:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f265d3bfac30c73f2e25c6c8321de693c9db5de
Cr-Commit-Position: refs/heads/master@{#397133}

Powered by Google App Engine
This is Rietveld 408576698