third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h - Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h

Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h b/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h

index beb9cda249475f33eba76268bd83427a09bbd243..a090efdb186e98861a486c15ad96bc13d90a541f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h

@@ -28,15 +28,14 @@

#include "bindings/core/v8/ActiveDOMCallback.h"

#include "bindings/core/v8/ScopedPersistent.h"

-#include "bindings/core/v8/ScriptState.h"

#include "core/dom/MutationCallback.h"

-#include "wtf/OwnPtr.h"

#include "wtf/RefPtr.h"

#include <v8.h>

namespace blink {

class ExecutionContext;

+class ScriptState;

class V8MutationCallback final : public MutationCallback, public ActiveDOMCallback {

USING_GARBAGE_COLLECTED_MIXIN(V8MutationCallback);

@@ -55,8 +54,6 @@ public:

private:

V8MutationCallback(v8::Local<v8::Function>, v8::Local<v8::Object>, ScriptState*);

- static void setWeakCallback(const v8::WeakCallbackInfo<V8MutationCallback>&);

ScopedPersistent<v8::Function> m_callback;

RefPtr<ScriptState> m_scriptState;

};