third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h - Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h

Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h

index d0cdfbe3e6942b25930c2aae34cf7ab69d8228f3..34fc5c30a7e7a6700d378e5cdcce9b79393d86cb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h

@@ -25,8 +25,6 @@ public:

ExecutionContext* getExecutionContext() const override { return ContextLifecycleObserver::getExecutionContext(); }

private:

- static void setWeakCallback(const v8::WeakCallbackInfo<V8IntersectionObserverCallback>&);

ScopedPersistent<v8::Function> m_callback;

RefPtr<ScriptState> m_scriptState;

};