Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp
index 8ef9ca9c6a6db9bdaf5b39b0d6e61ffded826b4f..13e9610523ade8cd7bcfe687f81825c39d6c988c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp
@@ -10,6 +10,7 @@
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8PerformanceObserver.h"
#include "bindings/core/v8/V8PerformanceObserverEntryList.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "core/dom/ExecutionContext.h"
#include "wtf/Assertions.h"
@@ -20,8 +21,8 @@ V8PerformanceObserverCallback::V8PerformanceObserverCallback(v8::Local<v8::Funct
, m_callback(scriptState->isolate(), callback)
, m_scriptState(scriptState)
{
- V8HiddenValue::setHiddenValue(scriptState, owner, V8HiddenValue::callback(scriptState->isolate()), callback);
- m_callback.setWeak(this, &setWeakCallback);
+ V8PrivateProperty::getPerformanceObserverCallback(scriptState->isolate()).set(scriptState->context(), owner, callback);
+ m_callback.setPhantom();
}
V8PerformanceObserverCallback::~V8PerformanceObserverCallback()
@@ -61,11 +62,6 @@ void V8PerformanceObserverCallback::handleEvent(PerformanceObserverEntryList* en
ScriptController::callFunction(m_scriptState->getExecutionContext(), m_callback.newLocal(m_scriptState->isolate()), thisObject, 2, argv, m_scriptState->isolate());
}
-void V8PerformanceObserverCallback::setWeakCallback(const v8::WeakCallbackInfo<V8PerformanceObserverCallback>& data)
-{
- data.GetParameter()->m_callback.clear();
-}
-
DEFINE_TRACE(V8PerformanceObserverCallback)
{
PerformanceObserverCallback::trace(visitor);

Powered by Google App Engine
This is Rietveld 408576698