third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h - Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h

Issue 2023213002: binding: Makes XxxObserverCallback use V8PrivateProperty instead of V8HiddenValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h

index f08cbf764959f611ee17daf1e07c9a3300a8f243..d875564088ecbc99d6467fea5fa90da66ca83e4c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h

@@ -30,8 +30,6 @@ public:

private:

CORE_EXPORT V8PerformanceObserverCallback(v8::Local<v8::Function>, v8::Local<v8::Object>, ScriptState*);

- static void setWeakCallback(const v8::WeakCallbackInfo<V8PerformanceObserverCallback>&);

ScopedPersistent<v8::Function> m_callback;

RefPtr<ScriptState> m_scriptState;

};