Change TextRun's length() and charactersLength() to return an unsigned

Change TextRun's length() and charactersLength() to return an unsigned

TextRun's m_len and m_charactersLength are unsigned but the accessors
for these values return ints. The values for length and charactersLength
cannot be negative so returning an integer just adds unnecessary casts
and potentially dangerous code.

Committed: https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855
Cr-Commit-Position: refs/heads/master@{#396776}

[pdr., 2016-05-28 05:29:24]

pdr@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[pdr., 2016-05-28 05:29:39]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-28 05:29:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018253002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018253002/1

[commit-bot: I haz the power, 2016-05-28 07:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 07:03:30]

Dry run: This issue passed the CQ dry run.

[drott, 2016-05-30 07:51:21]

Thank you! LGTM.

[pdr., 2016-05-31 02:01:01]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-05-31 02:01:02]

Thanks drott.

For posterity, the latest patchset is a rebase and also removes a trivial
static_cast I had to add in
https://crrev.com/433ceaeabee98073e81d552dee947aa6983efd53 in
Font::individualCharacterRanges. Because that patch will be merged into other
channels, I wanted to land it first to prevent merge conflicts.

Off to the CQ!

[pdr., 2016-05-31 02:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/2018253002/#ps20001
(title: "Rebase and remove one static_cast added in r396668")

[commit-bot: I haz the power, 2016-05-31 02:01:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018253002/20001

[commit-bot: I haz the power, 2016-05-31 03:28:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 03:30:10]

Description was changed from

==========
Change TextRun's length() and charactersLength() to return an unsigned

TextRun's m_len and m_charactersLength are unsigned but the accessors
for these values return ints. The values for length and charactersLength
cannot be negative so returning an integer just adds unnecessary casts
and potentially dangerous code.
==========

to

==========
Change TextRun's length() and charactersLength() to return an unsigned

TextRun's m_len and m_charactersLength are unsigned but the accessors
for these values return ints. The values for length and charactersLength
cannot be negative so returning an integer just adds unnecessary casts
and potentially dangerous code.

Committed: https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855
Cr-Commit-Position: refs/heads/master@{#396776}
==========

[commit-bot: I haz the power, 2016-05-31 03:30:12]

Patchset 2 (id:??) landed as
https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855
Cr-Commit-Position: refs/heads/master@{#396776}

[eae, 2016-05-31 17:49:09]

LGTM