third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp - Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp

Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and remove one static_cast added in r396668 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp ('k') | third_party/WebKit/Source/platform/text/TextRun.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp

index 07ea532c4be994cf530374459eb811949916efa5..1b92dfa06dd2edd13f60b28ee7646743e2afd194 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp

@@ -99,7 +99,7 @@ float SimpleShaper::adjustSpacing(float width, const CharacterData& charData)

m_runWidthSoFar += m_expansionPerOpportunity;

}

if (m_textRun.allowsTrailingExpansion()

- || (m_textRun.ltr() && charData.characterOffset + charData.clusterLength < static_cast<size_t>(m_textRun.length()))

+ || (m_textRun.ltr() && charData.characterOffset + charData.clusterLength < m_textRun.length())

|| (m_textRun.rtl() && charData.characterOffset)) {

m_expansion -= m_expansionPerOpportunity;

width += m_expansionPerOpportunity;