third_party/WebKit/Source/core/paint/TextPainter.h - Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TextPainter.h

Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and remove one static_cast added in r396668 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp ('k') | third_party/WebKit/Source/core/paint/TextPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TextPainter.h

diff --git a/third_party/WebKit/Source/core/paint/TextPainter.h b/third_party/WebKit/Source/core/paint/TextPainter.h

index 92b1ea7382e35e2aedb97f242d08b4ab091ab78e..bb7ae61af4c75df9a2ff6e8cf35316df859e239d 100644

--- a/third_party/WebKit/Source/core/paint/TextPainter.h

+++ b/third_party/WebKit/Source/core/paint/TextPainter.h

@@ -43,7 +43,7 @@ public:

static void updateGraphicsContext(GraphicsContext&, const Style&, bool horizontal, GraphicsContextStateSaver&);

- void paint(int startOffset, int endOffset, int length, const Style&, TextBlobPtr* cachedTextBlob = 0);

+ void paint(unsigned startOffset, unsigned endOffset, unsigned length, const Style&, TextBlobPtr* cachedTextBlob = 0);

struct Style {

STACK_ALLOCATED();

@@ -80,10 +80,10 @@ private:

enum PaintInternalStep { PaintText, PaintEmphasisMark };

template <PaintInternalStep step>

- void paintInternalRun(TextRunPaintInfo&, int from, int to);

+ void paintInternalRun(TextRunPaintInfo&, unsigned from, unsigned to);

template <PaintInternalStep step>

- void paintInternal(int startOffset, int endOffset, int truncationPoint, TextBlobPtr* cachedTextBlob = 0);

+ void paintInternal(unsigned startOffset, unsigned endOffset, unsigned truncationPoint, TextBlobPtr* cachedTextBlob = 0);

void paintEmphasisMarkForCombinedText();