Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: third_party/WebKit/Source/core/paint/TextPainter.h

Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and remove one static_cast added in r396668 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TextPainter.h
diff --git a/third_party/WebKit/Source/core/paint/TextPainter.h b/third_party/WebKit/Source/core/paint/TextPainter.h
index 92b1ea7382e35e2aedb97f242d08b4ab091ab78e..bb7ae61af4c75df9a2ff6e8cf35316df859e239d 100644
--- a/third_party/WebKit/Source/core/paint/TextPainter.h
+++ b/third_party/WebKit/Source/core/paint/TextPainter.h
@@ -43,7 +43,7 @@ public:
static void updateGraphicsContext(GraphicsContext&, const Style&, bool horizontal, GraphicsContextStateSaver&);
- void paint(int startOffset, int endOffset, int length, const Style&, TextBlobPtr* cachedTextBlob = 0);
+ void paint(unsigned startOffset, unsigned endOffset, unsigned length, const Style&, TextBlobPtr* cachedTextBlob = 0);
struct Style {
STACK_ALLOCATED();
@@ -80,10 +80,10 @@ private:
enum PaintInternalStep { PaintText, PaintEmphasisMark };
template <PaintInternalStep step>
- void paintInternalRun(TextRunPaintInfo&, int from, int to);
+ void paintInternalRun(TextRunPaintInfo&, unsigned from, unsigned to);
template <PaintInternalStep step>
- void paintInternal(int startOffset, int endOffset, int truncationPoint, TextBlobPtr* cachedTextBlob = 0);
+ void paintInternal(unsigned startOffset, unsigned endOffset, unsigned truncationPoint, TextBlobPtr* cachedTextBlob = 0);
void paintEmphasisMarkForCombinedText();

Powered by Google App Engine
This is Rietveld 408576698