third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h - Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and remove one static_cast added in r396668 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/Font.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

index 5d44f6573192566b054eb3a6dcb0ab89b11cf9e8..df556230ef2df0ce4520c92a5cfa259d030dd4e3 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

@@ -137,7 +137,7 @@ public:

ShapeCacheEntry* add(const TextRun& run, ShapeCacheEntry entry)

{

- if (static_cast<unsigned>(run.length()) > SmallStringKey::capacity())

+ if (run.length() > SmallStringKey::capacity())

return 0;

return addSlowCase(run, entry);

@@ -182,7 +182,7 @@ public:

private:

ShapeCacheEntry* addSlowCase(const TextRun& run, ShapeCacheEntry entry)

{

- int length = run.length();

+ unsigned length = run.length();

bool isNewEntry;

ShapeCacheEntry *value;

if (length == 1) {