third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp - Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

Issue 2018253002: Change TextRun's length() and charactersLength() to return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and remove one static_cast added in r396668 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

index 389ae19f4b87e7333c23d3686e145ad8b9addb5c..3685991a434e05f2c95c6f13cd8e1020877cbeab 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

@@ -205,7 +205,7 @@ float ShapeResultBuffer::fillGlyphBuffer(GlyphBuffer* glyphBuffer, const TextRun

unsigned from, unsigned to) const

{

// Fast path: full run with no vertical offsets

- if (!from && to == static_cast<unsigned>(textRun.length()) && !hasVerticalOffsets())

+ if (!from && to == textRun.length() && !hasVerticalOffsets())

return fillFastHorizontalGlyphBuffer(glyphBuffer, textRun.direction());

float advance = 0;