Enable strong mode in DDC, fix all warnings/errors

Enable strong mode in DDC, fix all warnings/errors

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4003b99d8340b7ee39d6478843f9b503252a028d

[Jennifer Messerly, 2016-05-25 21:24:46]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-05-26 17:53:38]

lgtm

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1843: setter, (node) =>
_emitTopLevelProperty(node)));
Annoying.  I guess alternatively emitDeclaration could take a second type
parameter for the type of the node that the function accepts and do the cast
internally to it.  Not sure that's better though.

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/type_utili...
File lib/src/compiler/type_utilities.dart (right):

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/type_utili...
lib/src/compiler/type_utilities.dart:165: var filter = formals?.expand((p) =>
_scopeDependencies[p] ?? <DartType>[]);
It sure would be nice if our final inference algorithm could handle this
pattern.

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dart
File lib/src/js_ast/template.dart (right):

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dar...
lib/src/js_ast/template.dart:572: (target, arguments) => new New(target,
arguments as List<Expression>));
line length?

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dar...
lib/src/js_ast/template.dart:576: (target, arguments) => new Call(target,
arguments as List<Expression>));
line length?

[Jennifer Messerly, 2016-05-26 18:11:48]

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1843: setter, (node) =>
_emitTopLevelProperty(node)));
On 2016/05/26 17:53:37, Leaf wrote:
> Annoying.  I guess alternatively emitDeclaration could take a second type
> parameter for the type of the node that the function accepts and do the cast
> internally to it.  Not sure that's better though.

yeah, that was my thought too. Seems like either way the cast is necessary.

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/type_utili...
File lib/src/compiler/type_utilities.dart (right):

https://codereview.chromium.org/2016483002/diff/1/lib/src/compiler/type_utili...
lib/src/compiler/type_utilities.dart:165: var filter = formals?.expand((p) =>
_scopeDependencies[p] ?? <DartType>[]);
On 2016/05/26 17:53:38, Leaf wrote:
> It sure would be nice if our final inference algorithm could handle this
> pattern.

Had the same thought :)

filed https://github.com/dart-lang/sdk/issues/26552

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dart
File lib/src/js_ast/template.dart (right):

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dar...
lib/src/js_ast/template.dart:572: (target, arguments) => new New(target,
arguments as List<Expression>));
On 2016/05/26 17:53:38, Leaf wrote:
> line length?

done. We should probably just start dartfmt'ing these. :)

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dar...
lib/src/js_ast/template.dart:576: (target, arguments) => new Call(target,
arguments as List<Expression>));
On 2016/05/26 17:53:38, Leaf wrote:
> line length?

Done.

https://codereview.chromium.org/2016483002/diff/1/lib/src/js_ast/template.dar...
lib/src/js_ast/template.dart:591: for (var r in result) callArguments.add(r);
BTW, not sure if it was obvious, but this pattern is because .addAll requires
Iterable<E> instead of Iterable<dynamic> (unlike `new List.from(...)`)

[Jennifer Messerly, 2016-05-26 18:13:34]

Description was changed from

==========
Enable strong mode in DDC, fix all warnings/errors
==========

to

==========
Enable strong mode in DDC, fix all warnings/errors

R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/4003b99d8340b7ee39d6478843f9...
==========

[Jennifer Messerly, 2016-05-26 18:13:36]

Committed patchset #2 (id:20001) manually as
4003b99d8340b7ee39d6478843f9b503252a028d (presubmit successful).