Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: tool/global_compile.dart

Issue 2016483002: Enable strong mode in DDC, fix all warnings/errors (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/analyze.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/global_compile.dart
diff --git a/tool/global_compile.dart b/tool/global_compile.dart
index 46404bae5ec76da39bceffdbe549f8152d35797a..673660a1671cb9a7b4ff66c826b6f8454577a39d 100644
--- a/tool/global_compile.dart
+++ b/tool/global_compile.dart
@@ -102,7 +102,7 @@ void main(List<String> args) {
: new Directory(tmp)..createSync();
for (var module in orderedModules) {
var file = tmpdir.path + path.separator + module + '.js';
- var command = new List.from(template)..addAll(['-o', file]);
+ var command = template.toList()..addAll(['-o', file]);
var dependences = transitiveDependenceMap[module];
for (var dependence in dependences) {
var summary = tmpdir.path + path.separator + dependence + '.sum';
@@ -111,9 +111,9 @@ void main(List<String> args) {
var infiles = fileMap[module];
command.addAll(infiles);
- var immediateDeps =
- dependenceMap.containsKey(module) ? dependenceMap[module] : <String>[];
- var waitList = immediateDeps.map((dep) => readyMap[dep]);
+ var waitList = dependenceMap.containsKey(module)
+ ? dependenceMap[module].map((dep) => readyMap[dep])
+ : <Future>[];
var future = Future.wait(waitList);
readyMap[module] = future.then((_) {
var ready = Process.run(dartPath, command);
« no previous file with comments | « tool/analyze.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698