Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: test/worker/worker_test.dart

Issue 2016483002: Enable strong mode in DDC, fix all warnings/errors (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen_test.dart ('k') | tool/analyze.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/worker/worker_test.dart
diff --git a/test/worker/worker_test.dart b/test/worker/worker_test.dart
index 2a5f0a7a0b2c612c2879aaed129dc5c7b3568725..662fc7f6d1b0325e7cef8c7b2089771ae18831a9 100644
--- a/test/worker/worker_test.dart
+++ b/test/worker/worker_test.dart
@@ -41,7 +41,7 @@ main() {
});
test('can compile in worker mode', () async {
- var args = new List.from(executableArgs)..add('--persistent_worker');
+ var args = executableArgs.toList()..add('--persistent_worker');
var process = await Process.start('dart', args);
var messageGrouper = new AsyncMessageGrouper(process.stdout);
@@ -73,7 +73,7 @@ main() {
});
test('can compile in basic mode', () {
- var args = new List.from(executableArgs)..addAll(compilerArgs);
+ var args = executableArgs.toList()..addAll(compilerArgs);
var result = Process.runSync('dart', args);
expect(result.exitCode, EXIT_CODE_OK);
@@ -85,7 +85,7 @@ main() {
test('can compile in basic mode with args in a file', () async {
argsFile.createSync();
argsFile.writeAsStringSync(compilerArgs.join('\n'));
- var args = new List.from(executableArgs)..add('@${argsFile.path}');
+ var args = executableArgs.toList()..add('@${argsFile.path}');
var process = await Process.start('dart', args);
stderr.addStream(process.stderr);
var futureProcessOutput = process.stdout.map(UTF8.decode).toList();
@@ -260,7 +260,7 @@ main() {
}
Future<WorkResponse> _readResponse(MessageGrouper messageGrouper) async {
- var buffer = await messageGrouper.next;
+ var buffer = (await messageGrouper.next) as List<int>;
try {
return new WorkResponse.fromBuffer(buffer);
} catch (_) {
« no previous file with comments | « test/codegen_test.dart ('k') | tool/analyze.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698