lib/src/js_ast/printer.dart - Issue 2016483002: Enable strong mode in DDC, fix all warnings/errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/js_ast/printer.dart

Issue 2016483002: Enable strong mode in DDC, fix all warnings/errors (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/js_ast/printer.dart

diff --git a/lib/src/js_ast/printer.dart b/lib/src/js_ast/printer.dart

index 87a104f364f3e774831d49589422dd795d7bf6bb..29bd7797c0335356a5e2fab89a39b3b627d5acb0 100644

--- a/lib/src/js_ast/printer.dart

+++ b/lib/src/js_ast/printer.dart

@@ -1406,7 +1406,9 @@ class VarCollector extends BaseVisitor {

nested = true;

if (fun.params != null) {

for (var param in fun.params) {

- params.add(param.name);

+ // TODO(jmesserly): add ES6 support. Currently not needed because

+ // dart2js does not emit ES6 rest param or destructuring.

+ params.add((param as Identifier).name);

}

fun.body.accept(this);

« no previous file with comments | « lib/src/js_ast/nodes.dart ('k') | lib/src/js_ast/template.dart » ('j') | no next file with comments »