Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: tool/analyze.sh

Issue 2016483002: Enable strong mode in DDC, fix all warnings/errors (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/worker/worker_test.dart ('k') | tool/global_compile.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 set -e 2 set -e
3 3
4 # Switch to the root directory of dev_compiler 4 # Switch to the root directory of dev_compiler
5 cd $( dirname "${BASH_SOURCE[0]}" )/.. 5 cd $( dirname "${BASH_SOURCE[0]}" )/..
6 6
7 function fail { 7 function fail {
8 echo -e "Analyzer found problems" 8 echo -e "Analyzer found problems"
9 return 1 9 return 1
10 } 10 }
11 11
12 # Run analyzer on bin/dartdevc.dart, as it includes most of the code we care 12 # Run analyzer on bin/dartdevc.dart, as it includes most of the code we care
13 # about via transitive dependencies. This seems to be the only fast way to avoid 13 # about via transitive dependencies. This seems to be the only fast way to avoid
14 # repeated analysis of the same code. 14 # repeated analysis of the same code.
15 # TODO(jmesserly): ideally we could do test/all_tests.dart, but 15 # TODO(jmesserly): ideally we could do test/all_tests.dart, but
16 # dart_runtime_test.dart creates invalid generic type instantiation AA. 16 # dart_runtime_test.dart creates invalid generic type instantiation AA.
17 echo "Running dartanalyzer to check for errors/warnings/hints..." 17 echo "Running dartanalyzer to check for errors/warnings/hints..."
18 dartanalyzer --fatal-warnings --package-warnings bin/dartdevc.dart \ 18 dartanalyzer --strong --fatal-warnings --package-warnings bin/dartdevc.dart \
19 | grep -v "\[info\] TODO" | (! grep $PWD) || fail 19 | grep -v "\[info\] TODO" | (! grep $PWD) || fail
OLDNEW
« no previous file with comments | « test/worker/worker_test.dart ('k') | tool/global_compile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698