Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: lib/src/compiler/js_metalet.dart

Issue 2016483002: Enable strong mode in DDC, fix all warnings/errors (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/compiler/element_helpers.dart ('k') | lib/src/compiler/module_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/compiler/js_metalet.dart
diff --git a/lib/src/compiler/js_metalet.dart b/lib/src/compiler/js_metalet.dart
index c0581d638a1ed6f1ac10fdcff68c98b7c63f954c..8e341fe5e341d6602dfd73da10405117002a7bb3 100644
--- a/lib/src/compiler/js_metalet.dart
+++ b/lib/src/compiler/js_metalet.dart
@@ -153,7 +153,7 @@ class MetaLet extends Expression {
return (args) => new MetaLet(
new Map.fromIterables(
variables.keys, valueInstantiators.map((i) => i(args))),
- bodyInstantiators.map((i) => i(args)).toList(),
+ bodyInstantiators.map((i) => i(args) as Expression).toList(),
statelessResult: statelessResult);
}
@@ -255,7 +255,8 @@ class MetaLet extends Expression {
assign = value.toAssignExpression(left);
}
- var newBody = new Expression.binary([assign]..addAll(body), ',');
+ assert(body.isNotEmpty);
+ Binary newBody = new Expression.binary([assign]..addAll(body), ',');
newBody = _substitute(newBody, {result: left});
return new MetaLet(vars, newBody.commaToExpressionList(),
statelessResult: statelessResult);
« no previous file with comments | « lib/src/compiler/element_helpers.dart ('k') | lib/src/compiler/module_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698