Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2014223002: Follow-up fixes to changing namespace gfx to gl. (Closed)

Created:
4 years, 7 months ago by kylechar
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, ozone-reviews_chromium.org, chromium-apps-reviews_chromium.org, kalyank, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow-up fixes to changing namespace gfx to gl. A follow up to changing the namespace gfx to namespace gl for all classes in ui/gl/* that fixes some code style issues. - Replace unnecessary fully qualified names, for example gl::ClassName used inside namespace gl can just be ClassName. - Fix namespace comments. - Other formatting. BUG=none Committed: https://crrev.com/fd721905a16823458cf0e8cfaa7f3e31710b6b29 Cr-Commit-Position: refs/heads/master@{#396480}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -158 lines) Patch
M ui/gl/android/scoped_java_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/gl_context.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_context_cgl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_cgl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_context_stub_with_extensions.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_wgl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_fence_egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M ui/gl/gl_helper.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/gl/gl_image_egl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_image_glx.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/gl/gl_image_ref_counted_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_ref_counted_memory_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/gl/gl_image_shared_memory_unittest.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M ui/gl/gl_image_surface_texture.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_image_surface_texture.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_implementation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_overlay.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_overlay.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_ozone.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M ui/gl/gl_surface_wgl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gpu_timing_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/test/gl_image_test_support.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/test/gl_image_test_template.h View 10 chunks +16 lines, -17 lines 0 comments Download
M ui/gl/trace_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/trace_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/yuv_to_rgb_converter.cc View 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kylechar
4 years, 7 months ago (2016-05-26 16:00:15 UTC) #2
piman
LGTM, thanks!
4 years, 7 months ago (2016-05-26 22:16:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014223002/20001
4 years, 6 months ago (2016-05-27 12:27:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 16:00:37 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 16:02:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd721905a16823458cf0e8cfaa7f3e31710b6b29
Cr-Commit-Position: refs/heads/master@{#396480}

Powered by Google App Engine
This is Rietveld 408576698