Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2008183002: DevTools: generate frontend and backend interfaces under domains. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, shans, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, timvolodine, caseq+blink_chromium.org, aboxhall, mvanouwerkerk+watch_chromium.org, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, cmumford, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, haraken, jsbell+idb_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: generate frontend and backend interfaces under domains. BUG=580337 Committed: https://crrev.com/237eccb244b101ec748ca1c1d3225a8af27f9a63 Cr-Commit-Position: refs/heads/master@{#395966}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : review comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -203 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/BackendCallback.h View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template View 1 chunk +24 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template View 1 chunk +1 line, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Frontend_h.template View 1 chunk +25 lines, -18 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/Object.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/Object.cpp View 1 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 1 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 2 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pfeldman
4 years, 7 months ago (2016-05-25 01:14:07 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2008183002/diff/20001/third_party/WebKit/Source/platform/inspector_protocol/Object.h File third_party/WebKit/Source/platform/inspector_protocol/Object.h (right): https://codereview.chromium.org/2008183002/diff/20001/third_party/WebKit/Source/platform/inspector_protocol/Object.h#newcode23 third_party/WebKit/Source/platform/inspector_protocol/Object.h:23: Object(std::unique_ptr<protocol::DictionaryValue>); explicit
4 years, 7 months ago (2016-05-25 17:10:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008183002/40001
4 years, 7 months ago (2016-05-25 17:57:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 19:51:18 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 19:52:23 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/237eccb244b101ec748ca1c1d3225a8af27f9a63
Cr-Commit-Position: refs/heads/master@{#395966}

Powered by Google App Engine
This is Rietveld 408576698