Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

Issue 2008183002: DevTools: generate frontend and backend interfaces under domains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
index 28c642581e28aa18d787ec5af69eb0bd2f76420d..a76ca1085a5ffd6e1f567e637704e11678be49f0 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
+++ b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
@@ -21,23 +21,8 @@ public:
static std::unique_ptr<Dispatcher> create(FrontendChannel* frontendChannel);
virtual ~Dispatcher() { }
- class PLATFORM_EXPORT CallbackBase {
- public:
- CallbackBase(std::unique_ptr<DispatcherImplWeakPtr> backendImpl, int callId);
- virtual ~CallbackBase();
- void sendFailure(const ErrorString&);
- void dispose();
-
- protected:
- void sendIfActive(std::unique_ptr<protocol::DictionaryValue> partialMessage, const ErrorString& invocationError);
-
- private:
- std::unique_ptr<DispatcherImplWeakPtr> m_backendImpl;
- int m_callId;
- };
-
{% for domain in api.domains %}
- virtual void registerAgent(blink::protocol::Backend::{{domain.domain}}*) = 0;
+ virtual void registerAgent(blink::protocol::{{domain.domain}}::Backend*) = 0;
{% endfor %}
virtual void clearFrontend() = 0;

Powered by Google App Engine
This is Rietveld 408576698