third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template - Issue 2008183002: DevTools: generate frontend and backend interfaces under domains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

Issue 2008183002: DevTools: generate frontend and backend interfaces under domains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Frontend_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

index e2c87915db49f48302cc65f5483e440f387e46f0..f32601f6e17c8ad6df7fd964b2372a5e09e01e67 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

@@ -18,11 +18,16 @@ Frontend::Frontend(FrontendChannel* frontendChannel)

{% endfor %}

{

}

{% for domain in api.domains %}

+{{domain.domain}}::Frontend* {{domain.domain}}::Frontend::from(protocol::Frontend* frontend)

+ return &(frontend->m_{{domain.domain | lower}});

{% for event in domain.events %}

{% if "handlers" in event and not ("renderer" in event["handlers"]) %}{% continue %}{% endif %}

-void Frontend::{{domain.domain}}::{{event.name}}(

+void {{domain.domain}}::Frontend::{{event.name}}(

{%- for parameter in event.parameters %}

{% if "optional" in parameter -%}

const Maybe<{{resolve_type(parameter).raw_type}}>&