third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp - Issue 2008183002: DevTools: generate frontend and backend interfaces under domains.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp

Issue 2008183002: DevTools: generate frontend and backend interfaces under domains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.h ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.

3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>	3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>

4 * Copyright (C) 2009 Google Inc. All rights reserved.	4 * Copyright (C) 2009 Google Inc. All rights reserved.

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 *	9 *

10 * 1. Redistributions of source code must retain the above copyright	10 * 1. Redistributions of source code must retain the above copyright

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 , m_name(name)	48 , m_name(name)

49 , m_version(version)	49 , m_version(version)

50 {	50 {

51 }	51 }

52	52

53 DEFINE_TRACE(InspectorDatabaseResource)	53 DEFINE_TRACE(InspectorDatabaseResource)

54 {	54 {

55 visitor->trace(m_database);	55 visitor->trace(m_database);

56 }	56 }

57	57

58 void InspectorDatabaseResource::bind(protocol::Frontend::Database* frontend)	58 void InspectorDatabaseResource::bind(protocol::Database::Frontend* frontend)

59 {	59 {

60 std::unique_ptr<protocol::Database::Database> jsonObject = protocol::Databas e::Database::create()	60 std::unique_ptr<protocol::Database::Database> jsonObject = protocol::Databas e::Database::create()

61 .setId(m_id)	61 .setId(m_id)

62 .setDomain(m_domain)	62 .setDomain(m_domain)

63 .setName(m_name)	63 .setName(m_name)

64 .setVersion(m_version).build();	64 .setVersion(m_version).build();

65 frontend->addDatabase(std::move(jsonObject));	65 frontend->addDatabase(std::move(jsonObject));

66 }	66 }

67	67

68 } // namespace blink	68 } // namespace blink

OLD	NEW