third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 2008183002: DevTools: generate frontend and backend interfaces under domains.

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2008183002: DevTools: generate frontend and backend interfaces under domains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index 44b692d355a95a5269affbeea95267e2d1f7f588..c53179cb87ad0321e7981be02738f1ac1d709792 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -55,17 +55,17 @@ V8InspectorSessionImpl::V8InspectorSessionImpl(V8DebuggerImpl* debugger, int con

m_state = protocol::DictionaryValue::create();

}

- m_runtimeAgent = wrapUnique(new V8RuntimeAgentImpl(this, protocol::Frontend::Runtime::from(m_frontend.get()), agentState("Runtime")));

- m_dispatcher->registerAgent(static_cast<protocol::Backend::Runtime*>(m_runtimeAgent.get()));

+ m_runtimeAgent = wrapUnique(new V8RuntimeAgentImpl(this, protocol::Runtime::Frontend::from(m_frontend.get()), agentState("Runtime")));

+ m_dispatcher->registerAgent(static_cast<protocol::Runtime::Backend*>(m_runtimeAgent.get()));

- m_debuggerAgent = wrapUnique(new V8DebuggerAgentImpl(this, protocol::Frontend::Debugger::from(m_frontend.get()), agentState("Debugger")));

- m_dispatcher->registerAgent(static_cast<protocol::Backend::Debugger*>(m_debuggerAgent.get()));

+ m_debuggerAgent = wrapUnique(new V8DebuggerAgentImpl(this, protocol::Debugger::Frontend::from(m_frontend.get()), agentState("Debugger")));

+ m_dispatcher->registerAgent(static_cast<protocol::Debugger::Backend*>(m_debuggerAgent.get()));

- m_heapProfilerAgent = wrapUnique(new V8HeapProfilerAgentImpl(this, protocol::Frontend::HeapProfiler::from(m_frontend.get()), agentState("HeapProfiler")));

- m_dispatcher->registerAgent(static_cast<protocol::Backend::HeapProfiler*>(m_heapProfilerAgent.get()));

+ m_heapProfilerAgent = wrapUnique(new V8HeapProfilerAgentImpl(this, protocol::HeapProfiler::Frontend::from(m_frontend.get()), agentState("HeapProfiler")));

+ m_dispatcher->registerAgent(static_cast<protocol::HeapProfiler::Backend*>(m_heapProfilerAgent.get()));

- m_profilerAgent = wrapUnique(new V8ProfilerAgentImpl(this, protocol::Frontend::Profiler::from(m_frontend.get()), agentState("Profiler")));

- m_dispatcher->registerAgent(static_cast<protocol::Backend::Profiler*>(m_profilerAgent.get()));

+ m_profilerAgent = wrapUnique(new V8ProfilerAgentImpl(this, protocol::Profiler::Frontend::from(m_frontend.get()), agentState("Profiler")));

+ m_dispatcher->registerAgent(static_cast<protocol::Profiler::Backend*>(m_profilerAgent.get()));

if (savedState) {

m_runtimeAgent->restore();