third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h - Issue 2008183002: DevTools: generate frontend and backend interfaces under domains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 2008183002: DevTools: generate frontend and backend interfaces under domains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

index 7c95d82379dae392004edaf20cea5a23643ed41b..5e9eecea2370e028bef92ad35641037f260f45d5 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

@@ -25,7 +25,7 @@ class DictionaryValue;

using protocol::Maybe;

-class V8DebuggerAgentImpl : public protocol::Backend::Debugger {

+class V8DebuggerAgentImpl : public protocol::Debugger::Backend {

PROTOCOL_DISALLOW_COPY(V8DebuggerAgentImpl);

public:

enum SkipPauseRequest {

@@ -42,7 +42,7 @@ public:

MonitorCommandBreakpointSource

};

- V8DebuggerAgentImpl(V8InspectorSessionImpl*, protocol::Frontend::Debugger*, protocol::DictionaryValue* state);

+ V8DebuggerAgentImpl(V8InspectorSessionImpl*, protocol::Debugger::Frontend*, protocol::DictionaryValue* state);

~V8DebuggerAgentImpl() override;

void restore();

@@ -207,7 +207,7 @@ private:

V8InspectorSessionImpl* m_session;

bool m_enabled;

protocol::DictionaryValue* m_state;

- protocol::Frontend::Debugger* m_frontend;

+ protocol::Debugger::Frontend* m_frontend;

v8::Isolate* m_isolate;

v8::Global<v8::Context> m_pausedContext;

JavaScriptCallFrames m_pausedCallFrames;