Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Issue 2003563003: [Autofill] Quality metric based on autocomplete attributes. (Closed)

Created:
4 years, 7 months ago by Mathieu
Modified:
4 years, 7 months ago
Reviewers:
sebsg, rkaplow
CC:
asvitkine+watch_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use autocomplete attributes, if available, as the golden truth basis for implementing a quality metric for heuristics and server predictions. Also, still apply server predictions to fields, even though an autocomplete attribute is present elsewhere in the form. BUG=613558 TEST=AutofillMetricsTest, FormStructureTest. Committed: https://crrev.com/092e1b75d75d7e74297f7cf1ea52bcf22924e167 Cr-Commit-Position: refs/heads/master@{#395158}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Total comments: 2

Patch Set 3 : histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -49 lines) Patch
M components/autofill/core/browser/autofill_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 2 chunks +10 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 2 chunks +25 lines, -11 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 3 chunks +64 lines, -29 lines 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 1 2 chunks +9 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Mathieu
Hi seb ptal?
4 years, 7 months ago (2016-05-20 15:01:32 UTC) #2
sebsg
LGTM with a small comment. Also could you remove the duplicate title in the CL ...
4 years, 7 months ago (2016-05-20 18:04:49 UTC) #3
Mathieu
https://codereview.chromium.org/2003563003/diff/1/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (right): https://codereview.chromium.org/2003563003/diff/1/components/autofill/core/browser/autofill_manager.cc#newcode884 components/autofill/core/browser/autofill_manager.cc:884: cur_form->LogQualityMetricsBasedOnAutocomplete(); On 2016/05/20 at 18:04:49, sebsg wrote: > The ...
4 years, 7 months ago (2016-05-20 18:56:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003563003/20001
4 years, 7 months ago (2016-05-20 18:58:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/187528)
4 years, 7 months ago (2016-05-20 19:06:01 UTC) #10
Mathieu
+rkaplow for histograms.xml
4 years, 7 months ago (2016-05-20 19:17:51 UTC) #12
rkaplow
https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histograms/histograms.xml#newcode90642 tools/metrics/histograms/histograms.xml:90642: + <suffix name="BasedOnAutocomplete" you can put this with the ...
4 years, 7 months ago (2016-05-20 19:25:23 UTC) #13
Mathieu
Thanks, have another look! https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histograms/histograms.xml#newcode90642 tools/metrics/histograms/histograms.xml:90642: + <suffix name="BasedOnAutocomplete" On 2016/05/20 ...
4 years, 7 months ago (2016-05-20 19:30:36 UTC) #14
rkaplow
lgtm
4 years, 7 months ago (2016-05-20 19:31:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003563003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003563003/40001
4 years, 7 months ago (2016-05-20 19:33:12 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 20:44:08 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 20:45:35 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/092e1b75d75d7e74297f7cf1ea52bcf22924e167
Cr-Commit-Position: refs/heads/master@{#395158}

Powered by Google App Engine
This is Rietveld 408576698