[Autofill] Quality metric based on autocomplete attributes.

Use autocomplete attributes, if available, as the golden truth basis for implementing a quality metric for heuristics and server predictions.

Also, still apply server predictions to fields, even though an autocomplete attribute is present elsewhere in the form.

BUG=613558
TEST=AutofillMetricsTest, FormStructureTest.

Committed: https://crrev.com/092e1b75d75d7e74297f7cf1ea52bcf22924e167
Cr-Commit-Position: refs/heads/master@{#395158}

[Mathieu, 2016-05-20 15:01:25]

mathp@chromium.org changed reviewers:
+ sebsg@chromium.org

[Mathieu, 2016-05-20 15:01:32]

Hi seb ptal?

[sebsg, 2016-05-20 18:04:49]

LGTM with a small comment. Also could you remove the duplicate title in the CL
description?

Very curious to see those metrics.

https://codereview.chromium.org/2003563003/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/2003563003/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager.cc:884:
cur_form->LogQualityMetricsBasedOnAutocomplete();
The comment here says "possibly" but the comment for
LogQualityMetricsBasedOnAutocomplete does not?

[Mathieu, 2016-05-20 18:56:54]

https://codereview.chromium.org/2003563003/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/2003563003/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager.cc:884:
cur_form->LogQualityMetricsBasedOnAutocomplete();
On 2016/05/20 at 18:04:49, sebsg wrote:
> The comment here says "possibly" but the comment for
LogQualityMetricsBasedOnAutocomplete does not?

Done.

[Mathieu, 2016-05-20 18:57:36]

Description was changed from

==========
[Autofill] Quality metric based on autocomplete attributes.

Use autocomplete attributes, if available, as the golden truth basis for
implementing a quality metric for heuristics and server predictions.

BUG=613558
TEST=AutofillMetricsTest
==========

to

==========
Use autocomplete attributes, if available, as the golden truth basis for
implementing a quality metric for heuristics and server predictions.

Also, still apply server predictions to fields, even though an autocomplete
attribute is present elsewhere in the form.

BUG=613558
TEST=AutofillMetricsTest, FormStructureTest.
==========

[Mathieu, 2016-05-20 18:57:38]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-05-20 18:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2003563003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-05-20 18:58:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003563003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003563003/20001

[commit-bot: I haz the power, 2016-05-20 19:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 19:06:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mathieu, 2016-05-20 19:17:33]

mathp@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Mathieu, 2016-05-20 19:17:51]

+rkaplow for histograms.xml

[rkaplow, 2016-05-20 19:25:23]

https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:90642: +  <suffix
name="BasedOnAutocomplete"
you can put this with the NoSubmission suffix. Each one doensn't need their own
histogram_suffixes

[Mathieu, 2016-05-20 19:30:36]

Thanks, have another look!

https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2003563003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:90642: +  <suffix
name="BasedOnAutocomplete"
On 2016/05/20 at 19:25:23, rkaplow wrote:
> you can put this with the NoSubmission suffix. Each one doensn't need their
own histogram_suffixes

Ok thanks.

[rkaplow, 2016-05-20 19:31:20]

lgtm

[Mathieu, 2016-05-20 19:32:38]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-05-20 19:32:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2003563003/#ps40001
(title: "histograms.xml")

[commit-bot: I haz the power, 2016-05-20 19:33:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003563003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003563003/40001

[commit-bot: I haz the power, 2016-05-20 20:44:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 20:45:34]

Description was changed from

==========
Use autocomplete attributes, if available, as the golden truth basis for
implementing a quality metric for heuristics and server predictions.

Also, still apply server predictions to fields, even though an autocomplete
attribute is present elsewhere in the form.

BUG=613558
TEST=AutofillMetricsTest, FormStructureTest.
==========

to

==========
Use autocomplete attributes, if available, as the golden truth basis for
implementing a quality metric for heuristics and server predictions.

Also, still apply server predictions to fields, even though an autocomplete
attribute is present elsewhere in the form.

BUG=613558
TEST=AutofillMetricsTest, FormStructureTest.

Committed: https://crrev.com/092e1b75d75d7e74297f7cf1ea52bcf22924e167
Cr-Commit-Position: refs/heads/master@{#395158}
==========

[commit-bot: I haz the power, 2016-05-20 20:45:35]

Patchset 3 (id:??) landed as
https://crrev.com/092e1b75d75d7e74297f7cf1ea52bcf22924e167
Cr-Commit-Position: refs/heads/master@{#395158}