Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2003563003: [Autofill] Quality metric based on autocomplete attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms.xml Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index f18ddfd1ec8df6b9ed9375950636878edf945cb5..e637fa550bdedcbdf055c1c6c81b97f11d465703 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -259,6 +259,13 @@ class AutofillMetrics {
NUM_FIELD_TYPE_QUALITY_METRICS,
};
+ enum QualityMetricType {
+ TYPE_SUBMISSION = 0, // Logged based on user's submitted data.
+ TYPE_NO_SUBMISSION, // Logged based on user's entered data.
+ TYPE_AUTOCOMPLETE_BASED, // Logged based on the value of autocomplete attr.
+ NUM_QUALITY_METRIC_TYPES,
+ };
+
// Each of these is logged at most once per query to the server, which in turn
// occurs at most once per page load.
enum ServerQueryMetric {
@@ -521,13 +528,13 @@ class AutofillMetrics {
static void LogHeuristicTypePrediction(FieldTypeQualityMetric metric,
ServerFieldType field_type,
- bool observed_submission);
+ QualityMetricType metric_type);
static void LogOverallTypePrediction(FieldTypeQualityMetric metric,
ServerFieldType field_type,
- bool observed_submission);
+ QualityMetricType metric_type);
static void LogServerTypePrediction(FieldTypeQualityMetric metric,
ServerFieldType field_type,
- bool observed_submission);
+ QualityMetricType metric_type);
static void LogServerQueryMetric(ServerQueryMetric metric);
« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/autofill_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698