[Autofill] Quality metric based on autocomplete attributes.

components/autofill/core/browser/form_structure_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/form_structure.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 3495 matching lines @@
   FormStructure::ParseQueryResponse(response_string, forms.get(), nullptr);
 
   ASSERT_GE(forms[0]->field_count(), 2U);
   ASSERT_GE(forms[1]->field_count(), 2U);
   EXPECT_EQ(7, forms[0]->field(0)->server_type());
   EXPECT_EQ(30, forms[0]->field(1)->server_type());
   EXPECT_EQ(9, forms[1]->field(0)->server_type());
   EXPECT_EQ(0, forms[1]->field(1)->server_type());
 }
 
-// If user defined types are present, only parse password fields.
 TEST_F(FormStructureTest, ParseQueryResponseAuthorDefinedTypes) {
   FormData form;
   form.origin = GURL("http://foo.com");
   FormFieldData field;
 
   field.label = ASCIIToUTF16("email");
   field.name = ASCIIToUTF16("email");
   field.form_control_type = "text";
   field.autocomplete_attribute = "email";
   form.fields.push_back(field);
 
   field.label = ASCIIToUTF16("password");
   field.name = ASCIIToUTF16("password");
   field.form_control_type = "password";
   field.autocomplete_attribute = "new-password";
   form.fields.push_back(field);
 
   ScopedVector<FormStructure> forms;
   forms.push_back(new FormStructure(form));
   forms.front()->DetermineHeuristicTypes();
 
   AutofillQueryResponseContents response;
-  response.add_field()->set_autofill_type(9);
-  response.add_field()->set_autofill_type(76);
+  response.add_field()->set_autofill_type(EMAIL_ADDRESS);
+  response.add_field()->set_autofill_type(ACCOUNT_CREATION_PASSWORD);
 
   std::string response_string;
   ASSERT_TRUE(response.SerializeToString(&response_string));
   FormStructure::ParseQueryResponse(response_string, forms.get(), nullptr);
 
   ASSERT_GE(forms[0]->field_count(), 2U);
-  EXPECT_EQ(NO_SERVER_DATA, forms[0]->field(0)->server_type());
-  EXPECT_EQ(76, forms[0]->field(1)->server_type());
+  // Server type is parsed from the response and is the end result type.
+  EXPECT_EQ(EMAIL_ADDRESS, forms[0]->field(0)->server_type());
+  EXPECT_EQ(EMAIL_ADDRESS, forms[0]->field(0)->Type().GetStorableType());
+  EXPECT_EQ(ACCOUNT_CREATION_PASSWORD, forms[0]->field(1)->server_type());
+  // TODO(crbug.com/613666): Should be a properly defined type, and not
+  // UNKNOWN_TYPE.
+  EXPECT_EQ(UNKNOWN_TYPE, forms[0]->field(1)->Type().GetStorableType());
 }
 
 TEST_F(FormStructureTest, FindLongestCommonPrefix) {
   // Normal case: All strings are longer than threshold; some are common.
   std::vector<base::string16> strings;
   strings.push_back(ASCIIToUTF16("1234567890123456789"));
   strings.push_back(ASCIIToUTF16("123456789012345678_foo"));
   strings.push_back(ASCIIToUTF16("1234567890123456"));
   strings.push_back(ASCIIToUTF16("12345678901234567890"));
   base::string16 prefix = FormStructure::FindLongestCommonPrefix(strings);
@@ skipping 23 matching lines @@
   prefix = FormStructure::FindLongestCommonPrefix(strings);
   EXPECT_EQ(ASCIIToUTF16("1234567890123456"), prefix);
 
   // Empty vector.
   strings.clear();
   prefix = FormStructure::FindLongestCommonPrefix(strings);
   EXPECT_EQ(ASCIIToUTF16(""), prefix);
 }
 
 }  // namespace autofill