Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2003563003: [Autofill] Quality metric based on autocomplete attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms.xml Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 1cfe52fd6bb092ead9c11ba88f586e6eb61b3fb7..5e1dfb04fef8283da8d8d466d82a9d93714cd65a 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -878,6 +878,11 @@ void AutofillManager::OnLoadedServerPredictions(
FormStructure::ParseQueryResponse(std::move(response), queried_forms,
client_->GetRapporService());
+ // Will log quality metrics for each FormStructure based on the presence of
+ // autocomplete attributes, if available.
+ for (FormStructure* cur_form : queried_forms)
+ cur_form->LogQualityMetricsBasedOnAutocomplete();
+
// Forward form structures to the password generation manager to detect
// account creation forms.
driver_->PropagateAutofillPredictions(queried_forms);
« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/autofill_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698