Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2003563003: [Autofill] Quality metric based on autocomplete attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms.xml Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 860 matching lines...) Expand 10 before | Expand all | Expand 10 after
871 871
872 // If there are no current forms corresponding to the queried signatures, drop 872 // If there are no current forms corresponding to the queried signatures, drop
873 // the query response. 873 // the query response.
874 if (queried_forms.empty()) 874 if (queried_forms.empty())
875 return; 875 return;
876 876
877 // Parse and store the server predictions. 877 // Parse and store the server predictions.
878 FormStructure::ParseQueryResponse(std::move(response), queried_forms, 878 FormStructure::ParseQueryResponse(std::move(response), queried_forms,
879 client_->GetRapporService()); 879 client_->GetRapporService());
880 880
881 // Will log quality metrics for each FormStructure based on the presence of
882 // autocomplete attributes, if available.
883 for (FormStructure* cur_form : queried_forms)
884 cur_form->LogQualityMetricsBasedOnAutocomplete();
885
881 // Forward form structures to the password generation manager to detect 886 // Forward form structures to the password generation manager to detect
882 // account creation forms. 887 // account creation forms.
883 driver_->PropagateAutofillPredictions(queried_forms); 888 driver_->PropagateAutofillPredictions(queried_forms);
884 889
885 // If the corresponding flag is set, annotate forms with the predicted types. 890 // If the corresponding flag is set, annotate forms with the predicted types.
886 driver_->SendAutofillTypePredictionsToRenderer(queried_forms); 891 driver_->SendAutofillTypePredictionsToRenderer(queried_forms);
887 } 892 }
888 893
889 IdentityProvider* AutofillManager::GetIdentityProvider() { 894 IdentityProvider* AutofillManager::GetIdentityProvider() {
890 return client_->GetIdentityProvider(); 895 return client_->GetIdentityProvider();
(...skipping 1097 matching lines...) Expand 10 before | Expand all | Expand 10 after
1988 if (i > 0) 1993 if (i > 0)
1989 fputs("Next oldest form:\n", file); 1994 fputs("Next oldest form:\n", file);
1990 } 1995 }
1991 fputs("\n", file); 1996 fputs("\n", file);
1992 1997
1993 fclose(file); 1998 fclose(file);
1994 } 1999 }
1995 #endif // ENABLE_FORM_DEBUG_DUMP 2000 #endif // ENABLE_FORM_DEBUG_DUMP
1996 2001
1997 } // namespace autofill 2002 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/autofill_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698