components/autofill/core/browser/form_structure.h - Issue 2003563003: [Autofill] Quality metric based on autocomplete attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 2003563003: [Autofill] Quality metric based on autocomplete attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: histograms.xml Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics_unittest.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.h

diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h

index 6a76db3cec7304f78cc7b332e476e413e0fbbd91..01971c9a1a7d1743eb885047539e631587bfc3fd 100644

--- a/components/autofill/core/browser/form_structure.h

+++ b/components/autofill/core/browser/form_structure.h

@@ -132,6 +132,11 @@ class FormStructure {

bool did_show_suggestions,

bool observed_submission) const;

+ // Log the quality of the heuristics and server predictions for this form

+ // structure, if autocomplete attributes are present on the fields (they are

+ // used as golden truths).

+ void LogQualityMetricsBasedOnAutocomplete() const;

// Classifies each field in |fields_| based upon its |autocomplete| attribute,

// if the attribute is available. The association is stored into the field's

// |heuristic_type|.